Add missing required and drop unnecessary required - #126
Draft
Yang-33 wants to merge 18 commits into
Draft
Conversation
Contributor
Author
|
I'll prepare the test changes for some repositories first, then open the PR. |
|
This pull request was closed because it has been inactive for 14 days. Please reopen if you still intend to submit this pull request, or submit issues at first. |
|
This pull request was closed because it has been inactive for 14 days. Please reopen if you still intend to submit this pull request, or submit issues at first. |
JAVAYou can check generated code in java |
NODEJSYou can check generated code in nodejs |
GOYou can check generated code in go |
RUBYYou can check generated code in ruby |
PHPYou can check generated code in php |
PYTHONYou can check generated code in python |
Yang-33
added a commit
to line/line-bot-sdk-nodejs
that referenced
this pull request
Aug 14, 2026
For form parameters, `undefined` values are not always omitted. This change fixes that behavior. Also, `description` is required for the `createAudienceForUploadingUserIds` API, but our OpenAPI definition appears to be incorrect. I will fix that separately in PR line/line-openapi#126. For now, let's merge this change first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an inconsistency between the OpenAPI specification (and generated SDKs) and the actual API behavior.
This change updates the required or optional annotations to match the actual behavior.
The behavior of the Messaging API itself is unchanged at all. This is purely a bug fix for the OpenAPI spec and the generated SDKs.
Affected methods
createAudienceGroupdescriptioncreateAudienceForUploadingUserIdsdescriptionaddAudienceToAudienceGroupaudienceGroupIdaudiencesaddUserIdsToAudienceaudienceGroupIdcreateClickBasedAudienceGroupdescriptionrequestIdcreateImpBasedAudienceGroupdescriptionrequestIdupdateAudienceGroupDescriptiondescriptiongetNumberOfFollowersdatecreateRichMenu/validateRichMenuObjectsize,selected,name,chatBarText,areascreateCouponrewardgetSharedAudienceGroupspagebot sdks we must fix
we must fix test depending on this.
go, ruby, nodejs, java are affected. line-openapi-126-prepare branch has this fix.
also 5c8b8c4 tested these remote branches, and https://github.com/line/line-openapi/actions/runs/31403474364?pr=126 showed all jobs were passed.