Fall back to jar when zip is missing for native debug symbols#263
Open
ScottMorris wants to merge 1 commit into
Open
Fall back to jar when zip is missing for native debug symbols#263ScottMorris wants to merge 1 commit into
ScottMorris wants to merge 1 commit into
Conversation
Tonight's real v0.2.0 release build showed native debug symbols never reached Google Play. Root cause: the tauri-ci-mobile container doesn't have `zip` installed, so `zip -r -q ... || true` failed silently on every phone build -- the `|| true` was there to avoid failing the whole Android job over a nice-to-have, but it also hid a failure that happened on every single run. Cargo's `strip = false` was working correctly; the .so files were genuinely unstripped and detected, only the archiving step was broken. `jar` (bundled with the JDK Gradle already needs to run) writes a standard PKZIP archive and works as a drop-in replacement, so this tries `zip` first and falls back to `jar` without adding a new dependency or touching the shared CI image (which lives in liminal-hq/.github, not this repo). Failures are now logged as a workflow warning instead of silently swallowed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xb6fbHiRvaNntsU1aVqF6w
ScottMorris
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spotted via the Play Console screenshot from tonight's real v0.2.0 release: the uploaded phone bundle only shows a "ReTrace mapping file" attached, no native debug symbols. Confirmed in the
build-androidjob logs:The
tauri-ci-mobilecontainer doesn't havezipinstalled. The debug-symbols archiving step was wrapped in|| true(originally meant to avoid failing the whole Android build over a nice-to-have artefact), which silently swallowed this on every single run -- Cargo'sstrip = falseis working fine, the.sofiles really are unstripped and get detected correctly, only the actual zip step was broken.Fix
Falls back to
jar cf(bundled with the JDK Gradle already requires to run, produces a standard PKZIP archive Play's deobfuscation upload accepts) whenzipisn't onPATH, instead of adding a new dependency or touching the shared CI image (which lives inliminal-hq/.github, not this repo, perCLAUDE.md). Also replaces the blanket|| truewith a::warning::annotation so a genuine future failure is visible in the run instead of silently disappearing again.Test plan
actionlint .github/workflows/release-build.yml-- cleanthreshold-phone-native-debug-symbols-v*.zipgets created and uploaded to PlayCo-Authored-By: Claude Sonnet 5 noreply@anthropic.com
https://claude.ai/code/session_01Xb6fbHiRvaNntsU1aVqF6w