Fix Deno workflows, native Deno projects, seed order and workspace exclusions - #33
Draft
likeBloodMoon wants to merge 1 commit into
Draft
likeBloodMoon wants to merge 1 commit into
likeBloodMoon wants to merge 1 commit into
Conversation
…ace exclusions Four findings from the review of #32: - init no longer gives a Deno project `deno install --frozen` as its install command, which is not a dependency install on every Deno version and stopped the workflow at its first step. Deno gets no install step; `deno task` fetches what the build needs. - A Deno project with no package.json gets a workflow that sets up Deno and runs `deno task build`, read from deno.json or deno.jsonc. A Deno config marks the project as Deno even before it has a lockfile. - A Next.js build's own page list is queued ahead of the sitemap, so a --max-pages limit cannot run out on sitemap entries first. - Exclusions in pnpm-workspace.yaml and package.json workspaces (`!apps/legacy`) are applied, so an excluded package is not offered as a site. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013BXnvSeRtgZoTXe4j753gM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four review findings on #32, which was merged before they were addressed. Each fix comes with a test that failed before it.
Changes
initno longer emitsdeno install --frozen. The action runsinstall-commandbefore the build, and that command is not a dependency install on every Deno version, so a Deno workflow could stop at its first step. Deno now gets no install step, sincedeno taskfetches what the build needs. An emptyinstall-commandalready skips the step inaction.yml.package.json.workflowForused to skip everything when there was nopackage.json. It now readsdeno.jsonordeno.jsoncfor abuildtask, and sets up Deno and runsdeno task build.//inside strings alone (task commands often contain URLs) and accepts trailing commas.--max-pages, the limit used to run out on sitemap entries first, leaving routes that only the Next.js build listed unrequested.!apps/legacyinpnpm-workspace.yaml, or inpackage.jsonworkspaces, is applied as a glob ignore, so an excluded package is no longer offered as a site.Verification
pnpm lint,pnpm typecheckandpnpm smokepass.pnpm test: 1,531 tests pass. The only failing file is the Playwright test, which fails the same way on master in this container because of a Chromium mismatch; CI installs Chromium itself.tests/cli/setup.test.ts(Deno withoutpackage.json, no Deno install step,deno.jsoncwith comments);tests/audit/crawl.test.ts(seeds survivemaxPageswith a larger sitemap);tests/audit/workspaces.test.ts(pnpm andpackage.jsonexclusions).🤖 Generated with Claude Code
https://claude.ai/code/session_013BXnvSeRtgZoTXe4j753gM
Generated by Claude Code