feat(config): icon-only source column with explanatory tooltip#46
Open
Terracosmos wants to merge 1 commit into
Open
feat(config): icon-only source column with explanatory tooltip#46Terracosmos wants to merge 1 commit into
Terracosmos wants to merge 1 commit into
Conversation
Replace the source pill text with an icon-only cell; the readable name and a business explanation now live in a v-tooltip (project convention: tooltips are v-tooltip, never native title). Unknown source types fall back to the raw source string. Adds FR/EN i18n under system.config.source and a test covering icon-only rendering, the tooltip, and the fallback. Refs #45
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45.
The Administration > Configuration table's "source" column now shows the source ICON only, instead of the icon + text label. Hovering the icon opens a v-tooltip (project convention: all tooltips are v-tooltip, never the native title attribute) with:
sourceExplanation()maps the known source types (systemEnvironment, systemProperties, applicationConfig, database, classpath) to i18n keys undersystem.config.source.*(EN + FR, plugin-local, merged at install()). Unknown source types fall back to the raw source string. CSV export is unchanged (still exports the readable label via exportValue: sourceLabel).Alignment note: the issue mentions left-aligning the column. With an icon-only cell the column was kept CENTER-aligned, which reads better for a single glyph; happy to switch to left if preferred.
Tests: vitest 32/32 (4 new in system-configuration-source.test.js) + npm run build OK. Verified at runtime on the real configuration set (icon only, bold name + explanation tooltip, unknown-source fallback).