DRY the interpolating value derivation code#7
Open
janjakubnanista wants to merge 1 commit into
Open
Conversation
janjakubnanista
force-pushed
the
jan/interpolating_value
branch
from
2cb688c to
e48d55a
Compare
janjakubnanista
force-pushed
the
jan/interpolating_value
branch
from
e48d55a to
48d5289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that branches out for the two cases (with/without participant groups) can be deduplicated since all the dependencies are present in
derive_interpolating_value. Also nocloneon the groups is needed as they can be borrowed.