Conversation
- Adds PHP 8.5 to the CI matrix.
- Bumps editorconfig-checker, nette/tester, phpstan, phpstan-strict-rules
and slevomat/coding-standard to current majors; this pulls in
php_codesniffer ^4.0.
- Updates phpcs.xml.dist for PHPCS 4.0:
- drops removed sniffs Generic.Functions.CallTimePassByReference and
Squiz.WhiteSpace.LanguageConstructSpacing
- migrates comma-separated array property values to <element> nodes
- replaces deprecated SlevomatCodingStandard.TypeHints.UnionTypeHintFormat
with DNFTypeHintFormat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
editorconfig-checker/editorconfig-checker,nette/tester,phpstan/phpstan,phpstan/phpstan-strict-rulesandslevomat/coding-standardto their current majors; this transitively brings insquizlabs/php_codesniffer^4.0.phpcs.xml.distto be PHPCS 4 compatible:Generic.Functions.CallTimePassByReferenceandSquiz.WhiteSpace.LanguageConstructSpacingsniffs<element>nodes (required by PHPCS 4)SlevomatCodingStandard.TypeHints.UnionTypeHintFormatwithDNFTypeHintFormatTest plan
composer checkpasses locally on PHP 8.5 (ec, phpcs, phpstan, tester all green)