fix(service): make Windows scheduler status locale independent - #736
fix(service): make Windows scheduler status locale independent#736luvs01 wants to merge 2 commits into
Conversation
📝 WalkthroughWalkthroughWindows ChangesWindows service status
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
LAND-AFTER — approved in principle, queued behind the release blockers. This resolves #722 correctly, and the approach is the right one. Rather than trying to decode CP949 out of Worth stating plainly since it is a contract change: What happens next: nothing is required from you. The two release blockers (#749, #737) are now on CI context (shared across the current review round). |
|
Closing as superseded — the fix is already on
The reason this needs to be closed rather than merged: Thanks for the fix; the direction was right and it shaped what landed. #722 is closed with the evidence above. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. Automatic draft conversion failed. Please convert this pull request to a draft manually until every box above is ticked. |
Summary
schtaskstable output with a locale-independent Windows scheduler status/healthzprobeFixes #722
Verification
bun scripts/test.ts tests/service.test.ts tests/windows-scheduler-install-verification.test.ts(58 passed, Bun 1.3.14)bun x tsc --noEmitbun scripts/privacy-scan.tscd docs-site && bun install --frozen-lockfile && bun run build(146 pages)git diff --checkdevslices continued making progress and completed, confirming a harness cutoff rather than a deadlock. The separate 5-secondcli-restore-backtest budget found during diagnosis is already covered by open security: harden post-merge service and management boundaries #707. Cross-platform CI still requires repository approval for this PR.Checklist
Summary by CodeRabbit
ocx service statuson Windows by separately reporting Task Scheduler registration and verified OpenCodex proxy availability.schtaskstables, keeping output readable across system code pages.Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.