devlog: work-phase 7 record — Bun 1.4 stack retargeted, not abandoned - #2377
Merged
Conversation
Records why the four-PR stack was rebuilt on dev rather than merged: only #2301 targeted dev, so dev CI never ran on the runtime diff, and a stacked merge would have reverted coordinator work that landed on src/cli/doctor.ts after the stack was cut (-94/+6 against current dev). #2302 was closed rather than landed. It coerces a missing or non-numeric extraMemorySize into 0 while the watchdog and doctor both type the field optional, so a counter that was never read would surface as jscExtra=0MB inside a series whose only purpose is showing whether native memory grows. Also records the wp1 holdout #2359 landing after the author fixed the exclusion that broke provider-live-models.test.ts:163, and the close of issue #2330 with the reasoning for the two slugs deliberately left exposed.
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a WP7 execution record that summarizes PR outcomes, diagnostics constraints, resolved blockers, experiment validation, deferred RSS recalculation, retained FAIL verdicts, and closure of holdout ChangesWP7 execution record
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records work-phase 7: the Bun 1.4 memory stack (#2301–#2304) was retargeted onto
devrather than abandoned, and071explains each of the four outcomes.The part worth reading is why the stack was not merged as a stack:
Coordinator remnant-recovery work landed on
doctor.tsafter the stack was cut, so merging the stacked head would have silently reverted it. Only visible if you diff the stacked head against currentdevinstead of trusting that a mergeable PR is a safe PR.It also records why #2302 was closed rather than landed: it coerces a missing or non-numeric
extraMemorySizeinto0, while the watchdog and doctor both type the field optional. A counter that was never read would surface asjscExtra=0MBinside a series whose only purpose is showing whether native memory grows. Shipping an observability feature that invents a zero is worse than shipping nothing.Plus the wp1 holdout: #2359 landed (
d179fa4f2) after the author dropped the exclusion that brokeprovider-live-models.test.ts:163, and #2330 closed with the reasoning for the two slugs deliberately left exposed — both are live, and hiding a served model is a worse bug than the one being fixed.What the record deliberately does not claim
The GC harness needs a live upstream fixture, so the recorded RSS cells were not regenerated and the
020table still carries the old denominator. Stated plainly rather than implied, because a harness that can prove the gate sitting next to a table that never did is exactly what gets misread as proof later.Verification
Docs only.
privacy:scanandrepo-hygienegreen in this unit; no production file touched.Checklist
devlog/Summary by CodeRabbit