Skip to content

devlog: work-phase 7 record — Bun 1.4 stack retargeted, not abandoned - #2377

Merged
lidge-jun merged 1 commit into
devfrom
codex/wp7-record
Aug 22, 2026
Merged

devlog: work-phase 7 record — Bun 1.4 stack retargeted, not abandoned#2377
lidge-jun merged 1 commit into
devfrom
codex/wp7-record

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Summary

Records work-phase 7: the Bun 1.4 memory stack (#2301#2304) was retargeted onto dev rather than abandoned, and 071 explains each of the four outcomes.

The part worth reading is why the stack was not merged as a stack:

git diff origin/dev cac21afb -- src/cli/doctor.ts   ->   -94/+6

Coordinator remnant-recovery work landed on doctor.ts after the stack was cut, so merging the stacked head would have silently reverted it. Only visible if you diff the stacked head against current dev instead of trusting that a mergeable PR is a safe PR.

It also records why #2302 was closed rather than landed: it coerces a missing or non-numeric extraMemorySize into 0, while the watchdog and doctor both type the field optional. A counter that was never read would surface as jscExtra=0MB inside a series whose only purpose is showing whether native memory grows. Shipping an observability feature that invents a zero is worse than shipping nothing.

Plus the wp1 holdout: #2359 landed (d179fa4f2) after the author dropped the exclusion that broke provider-live-models.test.ts:163, and #2330 closed with the reasoning for the two slugs deliberately left exposed — both are live, and hiding a served model is a worse bug than the one being fixed.

What the record deliberately does not claim

The GC harness needs a live upstream fixture, so the recorded RSS cells were not regenerated and the 020 table still carries the old denominator. Stated plainly rather than implied, because a harness that can prove the gate sitting next to a table that never did is exactly what gets misread as proof later.

Verification

Docs only. privacy:scan and repo-hygiene green in this unit; no production file touched.

Checklist

  • Docs-only
  • No security triage in devlog/
  • Numbered lexicographic filename

Summary by CodeRabbit

  • Documentation
    • Added an execution record covering outcomes from recent pull requests and the reasons for retargeting the work.
    • Documented fixes for whitespace handling, unavailable values, garbage-collection test baselines, signal gating, input validation, and scope claims.
    • Recorded deferred RSS regeneration, retained negative experiment results, and closure of related follow-up items.

Records why the four-PR stack was rebuilt on dev rather than merged: only
#2301 targeted dev, so dev CI never ran on the runtime diff, and a stacked
merge would have reverted coordinator work that landed on src/cli/doctor.ts
after the stack was cut (-94/+6 against current dev).

#2302 was closed rather than landed. It coerces a missing or non-numeric
extraMemorySize into 0 while the watchdog and doctor both type the field
optional, so a counter that was never read would surface as jscExtra=0MB
inside a series whose only purpose is showing whether native memory grows.

Also records the wp1 holdout #2359 landing after the author fixed the
exclusion that broke provider-live-models.test.ts:163, and the close of
issue #2330 with the reasoning for the two slugs deliberately left exposed.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner August 22, 2026 11:23
@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 13d4926a-3c71-40c1-b47e-a4dbb0388e6d

📥 Commits

Reviewing files that changed from the base of the PR and between 8923114 and 97286ee.

📒 Files selected for processing (1)
  • devlog/_plan/260822_backlog_disposition_program/071_wp7_execution_record.md

📝 Walkthrough

Walkthrough

Added a WP7 execution record that summarizes PR outcomes, diagnostics constraints, resolved blockers, experiment validation, deferred RSS recalculation, retained FAIL verdicts, and closure of holdout #2359 and issue #2330.

Changes

WP7 execution record

Layer / File(s) Summary
Execution outcomes and diagnostics
devlog/_plan/260822_backlog_disposition_program/071_wp7_execution_record.md
Records PR outcomes, the rationale for retargeting the stack, and why runtime diagnostics PR #2302 was not landed.
Validation and closure results
devlog/_plan/260822_backlog_disposition_program/071_wp7_execution_record.md
Records resolved measurement and harness blockers, deferred RSS regeneration, retained experiment FAIL verdicts, and closure details for holdout #2359 and issue #2330.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: ingwannu

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/wp7-record

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant