-
Notifications
You must be signed in to change notification settings - Fork 865
fix(claude): warm empty Desktop-3P alias registry on first /v1/messages after restart #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+74
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Target a guaranteed loopback address and add a timeout to the warm-up fetch.
The warm-up fetch at Line 1301 uses
new URL("/v1/models", url.origin).url.originreflects the inbound request's Host header, not a value the server controls. If a client sendsHost: localhost:<port>(or the server is configured with a non-defaulthostname), the self-fetch resolves that string independently ofbindHost. This file already documents that exact failure class a few lines earlier: "on Windowslocalhostresolves ::1-first, but the injected URL is 127.0.0.1". If the internal fetch takes the ::1 path (or any path other than the bound interface), it can fail or stall, and the surroundingtry/catchswallows the failure silently — the registry stays empty and the whole self-heal mechanism never engages for that process.Separately, the
fetch()call at Line 1301 has nosignal. Bun'sfetch()can hang without a bound when noAbortSignalis supplied. Since this call is awaited before the/v1/messageshandler runs, a stalled internal request delays the real client request for as long as the hang lasts.Use the actual bound loopback address and port, and cap the wait with
AbortSignal.timeout:🔧 Proposed fix
boundPortis safe to use here:/v1/messagesis not inloopbackRouteAllowed, so this branch is only reached via the primary listener, whose portboundPorttracks.📝 Committable suggestion
🤖 Prompt for AI Agents