-
Notifications
You must be signed in to change notification settings - Fork 887
fix(cursor): reuse conversation checkpoints for incremental continuation (#2054 rebased) #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,691
−37
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cba715e
fix(cursor): reuse conversation checkpoints for incremental continuation
keepitmello 560a85e
fix(cursor): pin store:false chat hops and helper-owned cache
keepitmello 09499fa
fix(cursor): keep recovered checkpoints and close review holes
keepitmello b12e53f
fix(cursor): fail closed on stale refs and prefix collisions
keepitmello 87d51ff
fix(cursor): frame checkpoint digests and drop stale recovery state
keepitmello a2f3c90
test(cursor): distinguish stale refs from ref-less fallback
lidge-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The captured post-turn
ConversationStateStructuremust already contain the assistant reply—otherwise the next ordinary checkpoint continuation, which sends only the new user action, would lose that reply—but this boundary counts only the request's input messages. If that next turn emits a tool call, the following tool-result request slices its suffix from this stale count and appends the already-checkpointed assistant reply again before the new user/tool exchange, duplicating model-visible history and potentially changing or invalidating the continuation. Record the actual expanded-message boundary including the generated assistant output before using it ascheckpointSuffixStart.AGENTS.md reference: src/AGENTS.md:L19-L19
Useful? React with 👍 / 👎.