-
Notifications
You must be signed in to change notification settings - Fork 858
fix(responses): route raw reasoning through the expandable summary channel (bridge + passthrough) #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lidge-jun
merged 4 commits into
lidge-jun:dev
from
AlinJiang:fix/route-raw-reasoning-to-summary-channel
Aug 18, 2026
Merged
fix(responses): route raw reasoning through the expandable summary channel (bridge + passthrough) #2007
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
56752d7
fix(responses): route raw reasoning through the expandable summary ch…
AlinJiang 96c2c04
fix(responses): preserve existing summary when content channel is empty
AlinJiang 2d5dc2a
fix(responses): cover non-streaming passthrough and case-insensitive …
AlinJiang 6f83963
fix(responses): keep hideThinkingSummary effective for passthrough re…
AlinJiang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,171 @@ | ||
| import type { SsePayloadRewrite } from "./sse-payload-rewrite"; | ||
|
|
||
| /** | ||
| * Route content-channel reasoning from native-Responses upstreams through the | ||
| * expandable summary channel (issue #45). | ||
| * | ||
| * Codex renders the expandable reasoning trace from the Responses reasoning | ||
| * item's `summary[]` channel. DeepSeek's native `/responses` endpoint emits | ||
| * raw thinking on the content channel instead (`response.reasoning_text.delta` | ||
| * plus items with `content: [{type: "reasoning_text", text}]` and an empty | ||
| * `summary`), so routed DeepSeek turns showed the "Worked for Xs" timer with | ||
| * nothing to expand. Native OpenAI upstreams already emit summary-channel | ||
| * events; this rewrite is a no-op for them (no reasoning_text events to | ||
| * rewrite) and only engages when the upstream produces content-channel | ||
| * reasoning. | ||
| * | ||
| * Replay compatibility: Codex echoes the reasoning item it received back into | ||
| * the next request's input. DeepSeek's Responses API accepts summary-shaped | ||
| * reasoning input items (verified live), so the rewrite round-trips. | ||
| */ | ||
|
|
||
| function isPlainObject(value: unknown): value is Record<string, unknown> { | ||
| return !!value && typeof value === "object" && !Array.isArray(value); | ||
| } | ||
|
|
||
| function reasoningTextOf(item: Record<string, unknown>): string { | ||
| if (!Array.isArray(item.content)) return ""; | ||
| return item.content | ||
| .filter((part): part is Record<string, unknown> => isPlainObject(part) && part.type === "reasoning_text") | ||
| .map(part => (typeof part.text === "string" ? part.text : "")) | ||
| .join(""); | ||
| } | ||
|
|
||
| /** Move a reasoning item's content channel into the summary channel. */ | ||
| function reasoningItemToSummaryShape(item: Record<string, unknown>): Record<string, unknown> { | ||
| if (item.type !== "reasoning") return item; | ||
| const text = reasoningTextOf(item); | ||
| // Items that already use the summary channel (or carry no content text at | ||
| // all) are left untouched: rewriting them could clear a valid summary. | ||
| if (text.length === 0) return item; | ||
| const next: Record<string, unknown> = { ...item }; | ||
| delete next.content; | ||
| next.summary = [{ type: "summary_text", text }]; | ||
| return next; | ||
| } | ||
|
|
||
| /** | ||
| * Rewrite one parsed SSE payload in place of the content channel, or return | ||
| * `null` when nothing changed (caller keeps the original payload). | ||
| */ | ||
| function rewritePayload(payload: Record<string, unknown>): Record<string, unknown> | null { | ||
| switch (payload.type) { | ||
| case "response.reasoning_text.delta": { | ||
| const next: Record<string, unknown> = { | ||
| type: "response.reasoning_summary_text.delta", | ||
| item_id: payload.item_id, | ||
| output_index: payload.output_index, | ||
| summary_index: 0, | ||
| delta: payload.delta, | ||
| }; | ||
| if (payload.sequence_number !== undefined) next.sequence_number = payload.sequence_number; | ||
| return next; | ||
| } | ||
| case "response.reasoning_text.done": { | ||
| const next: Record<string, unknown> = { | ||
| type: "response.reasoning_summary_text.done", | ||
| item_id: payload.item_id, | ||
| output_index: payload.output_index, | ||
| summary_index: 0, | ||
| text: payload.text, | ||
| }; | ||
| if (payload.sequence_number !== undefined) next.sequence_number = payload.sequence_number; | ||
| return next; | ||
| } | ||
| default: { | ||
| let changed = false; | ||
| const next: Record<string, unknown> = { ...payload }; | ||
| if (isPlainObject(next.item) && next.item.type === "reasoning") { | ||
| const rewritten = reasoningItemToSummaryShape(next.item); | ||
| if (rewritten !== next.item) { | ||
| next.item = rewritten; | ||
| changed = true; | ||
| } | ||
| } | ||
| // SSE event shape: {type: "response.completed", response: {output}}. | ||
| const response = isPlainObject(next.response) ? { ...next.response } : null; | ||
| if (response && Array.isArray(response.output)) { | ||
| const output = response.output.map(item => { | ||
| if (!isPlainObject(item) || item.type !== "reasoning") return item; | ||
| const rewritten = reasoningItemToSummaryShape(item); | ||
| if (rewritten !== item) changed = true; | ||
| return rewritten; | ||
| }); | ||
| if (changed) { | ||
| response.output = output; | ||
| next.response = response; | ||
| } | ||
| } | ||
| // Bare response document shape (non-streaming passthrough): | ||
| // {object: "response", output: [...]}. | ||
| if (Array.isArray(next.output)) { | ||
| const output = next.output.map(item => { | ||
| if (!isPlainObject(item) || item.type !== "reasoning") return item; | ||
| const rewritten = reasoningItemToSummaryShape(item); | ||
| if (rewritten !== item) changed = true; | ||
| return rewritten; | ||
| }); | ||
| if (changed) next.output = output; | ||
| } | ||
| return changed ? next : null; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** Payload rewrite for passthrough relays whose upstream emits content-channel reasoning. */ | ||
| export function createReasoningSummaryChannelPayloadRewrite(): SsePayloadRewrite { | ||
| return (payload: string): string => { | ||
| let parsed: unknown; | ||
| try { | ||
| parsed = JSON.parse(payload); | ||
| } catch { | ||
| return payload; | ||
| } | ||
| if (!isPlainObject(parsed)) return payload; | ||
| const rewritten = rewritePayload(parsed); | ||
| return rewritten !== null ? JSON.stringify(rewritten) : payload; | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Object-level variant for the non-streaming passthrough: the bounded-JSON | ||
| * relay bypasses the SSE payload rewrite, so reasoning items inside a full | ||
| * Responses JSON document need the same normalization before plain JSON | ||
| * serialization or forced JSON-to-SSE reframing. Returns the same reference | ||
| * when nothing changed. | ||
| */ | ||
| export function rewriteReasoningSummaryInJson(value: unknown): unknown { | ||
| if (!isPlainObject(value)) return value; | ||
| const rewritten = rewritePayload(value); | ||
| return rewritten !== null ? rewritten : value; | ||
| } | ||
|
|
||
| /** String-level variant of {@link rewriteReasoningSummaryInJson}. */ | ||
| export function rewriteReasoningSummaryInJsonString(json: string): string { | ||
| let parsed: unknown; | ||
| try { | ||
| parsed = JSON.parse(json); | ||
| } catch { | ||
| return json; | ||
| } | ||
| const rewritten = rewriteReasoningSummaryInJson(parsed); | ||
| return rewritten === parsed ? json : JSON.stringify(rewritten); | ||
| } | ||
|
|
||
| /** | ||
| * True when a routed native-Responses provider emits content-channel reasoning | ||
| * (raw `reasoning_text`) instead of the summary channel. DeepSeek's | ||
| * `/responses` endpoint is the current example: it ships raw thinking with an | ||
| * empty `summary` and keeps `preserveReasoningContentModels` so multi-turn | ||
| * replays round-trip. | ||
| */ | ||
| export function routeUsesContentChannelReasoning( | ||
| provider: { statelessResponses?: boolean; preserveReasoningContentModels?: string[] }, | ||
| modelId: string, | ||
| ): boolean { | ||
| if (provider.statelessResponses === true) return true; | ||
| const preserved = provider.preserveReasoningContentModels; | ||
| const normalizedModelId = modelId.toLowerCase(); | ||
| return Array.isArray(preserved) | ||
| && preserved.some(id => id.toLowerCase() === normalizedModelId); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.