ci: classify Bun epoll faults as runtime crashes - #1475
Merged
Conversation
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI helper now classifies a status-1 Bun failure as a runtime crash only when the log contains the required epoll ChangesBun crash detection
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EEXIST: file already exists, epoll_ctlfailure from internalWriteStreamsetup as a Bun runtime crash even when Bun exits with status 1.epoll_ctlerror, and aninternal:fs/streamsWriteStreamframe.This addresses the runtime failure seen in the Linux test shard for #1457, where the existing #1469 fallback was skipped because the Bun runtime fault exited with status 1.
Verification
bash -n scripts/ci/run-bun-test-batches.sh— pass.devdetector does not classify the exit-1epoll_ctlfault as runtime; patched detector does.epoll_ctlruntime signature on a two-file batch -> classified as runtime, singleton recovery runs, both singleton processes pass, helper exits 0;EEXIST ... epoll_ctlwithout Bun's internalWriteStreamframe -> no singleton retry, helper exits 1.dev(6031deb91f78ca7d93f087719c5c460ec9f9ee95) before applying the 10-line patch.bun run typecheck/bun run testwere not executable in the current tool environment because it does not have a Bun binary. Repository CI should provide the Bun-native validation.Checklist
Summary by CodeRabbit