Skip to content

fix(officecli): warn when resident keeps files locked - #320

Merged
parkjs101 merged 1 commit into
devfrom
codex/p2-officecli-lock-297
Aug 12, 2026
Merged

fix(officecli): warn when resident keeps files locked#320
parkjs101 merged 1 commit into
devfrom
codex/p2-officecli-lock-297

Conversation

@parkjs101

@parkjs101 parkjs101 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • update the officecli submodule from dbcfb23e to merged OfficeCLI PR MCP Sync 전역 전환: syncToAll → global paths only + Antigravity 타겟 추가 #3 (59e4774a)
  • make officecli create explicitly warn that its background resident may keep the file locked
  • print the exact officecli close "<file>" recovery command
  • name move, rename, delete, and external-open operations that require closing first
  • document and test the lock-warning contract

Why

The resident behavior is intentional, but the old success message described only its performance benefit. On Windows the resident can hold a mandatory lock, causing the next filesystem operation to fail without telling users that close is required.

Validation

  • OfficeCLI PR #3 merged
  • targeted OfficeCLI regression test passed (1/1)
  • Windows built-CLI smoke: create emitted the warning and exited 0
  • the printed close command released the resident and exited 0
  • temporary workbook removed successfully after close
  • structure/verify-counts.sh passed on current origin/dev
  • parent diff contains only the officecli gitlink update

Closes #297

Summary by CodeRabbit

  • Chores
    • Updated the bundled office command-line tooling to a newer version.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8135abf5-9944-4d5f-ab83-db15582d74d3

📥 Commits

Reviewing files that changed from the base of the PR and between 896ff95 and e4b5874.

📒 Files selected for processing (1)
  • officecli

📝 Walkthrough

Walkthrough

The officecli submodule reference changes from commit dbcfb23e8e5f96584646fd2ab961a53010808342 to commit 59e4774a48b3ead171490c04308544fdfcc5dd24.

Changes

officecli reference update

Layer / File(s) Summary
Update officecli submodule pointer
officecli
The submodule pointer now references commit 59e4774a48b3ead171490c04308544fdfcc5dd24.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: lidge-j

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the officecli resident lock warning, which is the primary change described in the objectives.
Linked Issues check ✅ Passed The update addresses issue #297 by warning about resident-held locks and directing users to close files before filesystem operations.
Out of Scope Changes check ✅ Passed The submodule update aligns with issue #297 and the stated warning and recovery guidance objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/p2-officecli-lock-297

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@parkjs101
parkjs101 marked this pull request as ready for review August 12, 2026 09:51
@parkjs101
parkjs101 merged commit 37dac3a into dev Aug 12, 2026
2 checks passed
@parkjs101
parkjs101 deleted the codex/p2-officecli-lock-297 branch August 18, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant