Repository navigation
feat(spawn): let a session set its own model and effort, and close itself on self - #944
Merged
Merged
Conversation
…self on self control_session took model and effort on any Claude Code session but the caller's own, though both only change what the next requests carry and the asking turn survives them. close_session refused the caller outright, leaving the user no way to have an agent close its own session. model and effort now reach the caller; close_session (lich close --self) closes it when told self, which the tool description reserves for a user who asked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
control_sessionnow acceptsmodelandeffortwith the caller's own session as the target. Both only change what the session's next requests carry, so the asking turn survives them.abort,promptand slash commands on the caller stay refused, since they cannot work there.close_sessiongainsself(lich close --self), which lifts the refusal to close the session the call runs in. The tool description reserves it for a user who asked; nothing verifies that, anddocs/ceilings.mdsays so.CloseSessionOptionsgainsself;api/testdata/contract.goldenregenerated because the contract moved.Test plan
TestControlSetsTheCallersOwnModelAndEffort: model and effort reach the caller.TestCloseTakesDownTheCallerWhenToldSelf: the caller is parked and its terminal closed withself.self) still hold.gofmt,go vet ./...,go test ./...green.