Repository navigation
feat(native): hand a PR off from Pulls without leaving it - #935
Merged
Merged
Conversation
Resolve conflicts and Fix CI errors no longer bring up the session they hand the pull request to. The window spawns it off screen through the spawn gate's own decision, sends the prompt, and raises a toast with Open once it lands. A spawn that needs the user (the resume prompt, a checkout gone) still brings the session up. The busy state ends when the session is born, so the next pull request's button is free.
Send to session goes through the same handoff as Resolve conflicts and Fix CI errors: the session spawns off screen unless its spawn needs the user, and the toasts carry Open. Its busy state still lasts until the threads are recorded as waiting, so a second click cannot send them twice.
omartelo
force-pushed
the
feat/pulls-handoff-stays
branch
from
October 24, 2026 10:49
a6b4e65 to
41365ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve conflicts and Fix CI errors in Pulls used to switch the window to the session they hand the pull request to. Now Pulls stays on screen, so the next pull request is one click away:
spawnGate.unseentakes the same decision that first view would (live, plain, resume, fresh). When the gate needs the user (the resume prompt, a checkout gone), the session comes up as before.handOffPR), with Open on its toasts. Its busy state still lasts until the threads are recorded as waiting, so a second click cannot send them twice.addWorktreeSessionandshowNewSessionnow split recording or loading a session from putting it on screen, andsubmitAtPromptsplits intohandOff(the error) and the toast.New key
pulls.pulls.handedOffin every locale. CHANGELOG entry under Unreleased › Changed.Test plan
TestHandoffLeavesThePullsScreenUp: Start and Submit reach the backend, Pulls stays open, the session is not made active.TestOpenSessionBringsTheSessionUp: no prompt hides Pulls and activates the session.TestUnseenSpawnsWhatTheFirstViewWould: every gate verdict, and no resume prompt raised.TestSendThreadsLeavesThePullsScreenUp: Start, Submit and AwaitThreadFix reach the backend, Pulls stays open, the session is not made active.-race -count=100green.native/: gofmt, go vet, go test ./... green.