Skip to content

fix: guard REX::W32 MAX_PATH/ERROR against header-only spdlog leaking… #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qudix merged 1 commit into from
Jul 2, 2026
Merged

fix: guard REX::W32 MAX_PATH/ERROR against header-only spdlog leaking… #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/REX/W32/MACRO_GUARD_BEGIN.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#pragma push_macro("MAX_PATH")
#pragma push_macro("ERROR")
#undef MAX_PATH
#undef ERROR
2 changes: 2 additions & 0 deletions include/REX/W32/MACRO_GUARD_END.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#pragma pop_macro("ERROR")
#pragma pop_macro("MAX_PATH")
4 changes: 4 additions & 0 deletions src/REX/LOG.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

#include <spdlog/spdlog.h>

#include "REX/W32/MACRO_GUARD_BEGIN.h"

namespace REX::Impl
{
void Log(const std::source_location a_loc, const ELogLevel a_level, const std::string_view a_fmt)
Expand Down Expand Up @@ -172,3 +174,5 @@ namespace REX::Impl
REX::W32::TerminateProcess(REX::W32::GetCurrentProcess(), 1);
}
}

#include "REX/W32/MACRO_GUARD_END.h"
Loading