Stricter checks (RSA OAEP, X25519, X448) - based on wycheproof results#753
Merged
Stricter checks (RSA OAEP, X25519, X448) - based on wycheproof results#753
Conversation
sjaeckel
force-pushed
the
pr/wycheproof-pk-stricter-checks
branch
from
2462a42 to
e5fc656
Compare
sjaeckel
force-pushed
the
pr/wycheproof-pk-stricter-checks
branch
from
e5fc656 to
2c375b3
Compare
sjaeckel
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes libtomcrypt checks stricter for a few Wycheproof test cases.
While checking Wycheproof results, I found some tests marked as acceptable that our code does not reject. These cases can technically be tolerated when they pass, but I think these three are worth rejecting: