Rename 'Configuration files' label and add a correct and precise description to its sub-label#19248
Open
davidhedlund wants to merge 1 commit into
Open
Rename 'Configuration files' label and add a correct and precise description to its sub-label#19248davidhedlund wants to merge 1 commit into
davidhedlund wants to merge 1 commit into
Conversation
…ription to its sub-label Fixes: * libretro#19200
Collaborator
|
Seems good. Thanks for working on it. |
Contributor
|
Looks fine to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace:
With:
Rationale:
Configurations. Matches the defaultconfigdestination directory used by thergui_config_directoryvariable.Configuration files: Lowercase initial words are non-standard for labels; standardizing "Configuration Files" to capital "F" risks confusing users into thinking it only affects items underMain Menu → Configuration Files, whereas it is also used for saving overrides (e.g.,Quick Menu → Overrides → Save Core OverridesandQuick Menu → Core Options → Save Game Options).Overridesto the label to prevent confusion that it is limited exclusively toQuick Menu → Overrides(capital "O"), given that it also handles other items likeQuick Menu → Core Options. Additionally, since overrides are inherently configurations, using the simpler termConfigurationskeeps the label concise and all-encompassing.Default configuration file is stored in this directory.:Main Menu → Configuration Filethat does not save to theSettings → Directory → Configuration filesdirectory.Related Issues
Reviewers
@hizzlekizzle @Ryunam