menu: Use focus to determine OSK/textbox behavior#19221
Open
Ryunam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the concerns raised in #19213, I have reworked the OSK/textbox behavior to retain compatibility with controller keyboards (such as the IPAC devices mentioned in that PR) while still preserving the improvements to text typing with physical keyboards.
This PR adds a new focus switching mechanism:
Two ways are provided for switching the focus between OSK and textbox:
A few pictures of how the focus looks with the different menu drivers.
Ozone:
Focus on OSK (default)

Focus on textbox

MaterialUI / GLUI
Focus on OSK (default)

Focus on textbox

XMB
Focus on OSK (default)

Focus on textbox

RGUI
Focus on OSK (default)

Focus on textbox

Reviewers
@sonninnos