show message when changing disks - #52
Open
Jamiras wants to merge 1 commit into
Open
Conversation
Jamiras
commented
Aug 26, 2026
| MessageManager::_messageManager->DisplayMessage(title, message); | ||
| } else { | ||
| MessageManager::Log("[" + title + "] " + message); | ||
| } |
Author
There was a problem hiding this comment.
Copied some logic from the upstream repository to allow messages to actually be displayed instead of just logged.
| } | ||
| } | ||
|
|
||
| ReportDiskChange(); |
Author
There was a problem hiding this comment.
The actual process of switching disks is to immediately eject the disk, then insert the new disk two seconds later.
Mesen/Core/FdsSystemActionManager.h
Line 87 in 0102910
So, on button press, the "Ejected disk" message is shown and a bit is set on _currentDisk. While the bit is set, ReportDiskChange will check to see if the new disk has been inserted, then show a "Inserted disk" message and clear the bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides feedback when using the shoulder buttons to change disks in FDS mode.