Repository navigation
fix(helper): remove 0.17.0 first-paint tab flash - #63
Merged
Merged
Conversation
The guide is one large self-contained file, so before the tab script runs the browser painted every panel stacked (a long flat scroll on first open). Mark the inactive tab panels hidden in the markup so the first paint already matches the tabbed view; the script then manages switching as before. Only 19 hidden attributes added to inactive panels, no content change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.17.0 guide is a large single file; before the tab script ran, the first paint showed every panel stacked as one long scroll. This marks inactive tab panels
hiddenin the markup so the initial paint already shows the tabbed view. Verified: with JS off only the active panels render (normal height), with JS on the tab switching still works and no console errors. Only 19hiddenattributes added, no content change.