Repository navigation
docs(backlog): record the two inline-connection id readers that still answer 500 (D245) - #1578
Merged
Merged
Conversation
… answer 500 (D244) Found in the review of #1572: resolveConnection calls startsWith on a non-string id before the custom-connection policy check, and withOneShotTunnel hands a missing id to the tunnel pool key before validate() can refuse it.
cevheri
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds D245 to docs/BACKLOG.md, found in the review of #1572. Both predate it:
resolveConnectionanswers 500 for a non-string inlineid(before the ALLOW_CUSTOM_CONNECTIONS check, so a 403 becomes a 500), andwithOneShotTunnelpasses a missingidto the tunnel pool key beforevalidate()can answer 400. backlog-structure and agent-documentation tests pass.