Repository navigation
build: fix broken tests, add CI - #31
Merged
Merged
Conversation
Bnyro
reviewed
Oct 25, 2026
| - uses: actions/checkout@v5 | ||
| - run: rustup update stable && rustup default stable | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - run: cargo clippy --workspace --all-targets --locked -- -D warnings |
Member
There was a problem hiding this comment.
All in all, we're installing 5 rust targets (3x test, 1x fmt, 1x clippy). Is that really needed? It certainly makes the CI slower.
Any why are we using the nightly formatter, but stable clippy?
Contributor
Author
There was a problem hiding this comment.
All in all, we're installing 5 rust targets (3x test, 1x fmt, 1x clippy). Is that really needed? It certainly makes the CI slower.
It'll get faster once GitHub updates the pre-installed versions :) Alternatively we could also use the older, installed ones, at the risk of missing out of features/fixes in newer rust releases.
Any why are we using the nightly formatter, but stable clippy?
Swapped to stable.
Member
There was a problem hiding this comment.
But not pushed yet? :)
Lgtm then!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken tests and adds a CI workflow that runs on every commit/PR to avoid breaking the tests in the future.