deps!: Update multiaddr & multihash to 0.17.0 by ppodolsky · Pull Request #3196 · libp2p/rust-libp2p

ppodolsky · 2022-12-06T08:01:19Z

Description

Notes

Dependabot forgot to update multihash in https://github.com/libp2p/rust-libp2p/pull/3193/files, fixed this.

Depends-On: #3203

b5 · 2022-12-06T18:49:14Z

👋 libp2p team, would love to know if this is mergable. It's a blocker on n0-computer/iroh#546 for us in iroh. Thanks!

thomaseizinger

LGTM, thank you!

I kicked CI.

thomaseizinger · 2022-12-07T04:50:44Z

The failing interop test should be fixed once #3203 is merged.
The two failing semver tests are due to a bug in cargo semver-checks: #2647 (comment)

@mxinden Will need to exercise his admin rights to merge this until we have that sorted.

ppodolsky · 2022-12-08T08:00:46Z

@thomaseizinger Hi! Could you push it forward? Is there anything I can do to help?

thomaseizinger · 2022-12-12T01:42:10Z

@thomaseizinger Hi! Could you push it forward? Is there anything I can do to help?

Nope, I don't have the admin rights to merge a PR with failing builds. We need to merge and release #3213 to fix the false-positive reports from cargo semver-checks.

thomaseizinger · 2022-12-12T01:47:16Z

I've approved it to go into the merge-queue but that won't happen until the build is green. Keep an eye on the conversation in #3213. Once that is resolved and released, you should be able to get this in by updating it with latest master to trigger CI again at which point it should automatically go in once it is green!

mxinden

Thanks for the patch @ppodolsky.

mergify · 2022-12-12T21:00:18Z

This pull request has merge conflicts. Could you please resolve them @ppodolsky? 🙏

mxinden · 2022-12-14T13:42:35Z

@ppodolsky I seem to not have permissions to push to your branch. Can you please cherry pick mxinden@72248a1 ?

@thomaseizinger any objections including this in the next release? In other words, any objections in doing a full breaking change for the next release?

ppodolsky · 2022-12-14T13:45:54Z

Done

thomaseizinger · 2022-12-19T05:30:19Z

@thomaseizinger any objections including this in the next release? In other words, any objections in doing a full breaking change for the next release?

Nope, fine with me!

Addressed.

thomaseizinger · 2022-12-19T06:46:58Z

Mergify can't update your branch to the latest version of master: https://github.com/libp2p/rust-libp2p/pull/3196/checks?check_run_id=10175104797

Can you see if you can address this? I've heard that it is tricky to do for forks coming from organisations but haven't confirmed that. Worst case, can you open this PR from a personal fork instead?

Updates the requirements on [multiaddr](https://github.com/multiformats/rust-multiaddr) to permit the latest version. - [Release notes](https://github.com/multiformats/rust-multiaddr/releases) - [Changelog](https://github.com/multiformats/rust-multiaddr/blob/master/CHANGELOG.md) - [Commits](multiformats/rust-multiaddr@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: multiaddr dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

Approvals have been dismissed because the PR was updated after the send-it label was applied.

ppodolsky · 2022-12-19T06:53:59Z

Mergify can't update your branch to the latest version of master: https://github.com/libp2p/rust-libp2p/pull/3196/checks?check_run_id=10175104797

Can you see if you can address this? I've heard that it is tricky to do for forks coming from organisations but haven't confirmed that. Worst case, can you open this PR from a personal fork instead?

Done, but had to force push rebased commits.
I believe organisations' forks are ok if the organisation belongs to you.

thomaseizinger · 2022-12-19T07:01:50Z

Mergify can't update your branch to the latest version of master: #3196 (checks)
Can you see if you can address this? I've heard that it is tricky to do for forks coming from organisations but haven't confirmed that. Worst case, can you open this PR from a personal fork instead?

Done, but had to force push rebased commits. I believe organisations' forks are ok if the organisation belongs to you.

Cool thanks! Let's see if mergify is happy now :)

Approvals have been dismissed because the PR was updated after the send-it label was applied.

mergify · 2022-12-19T13:30:37Z

This pull request has merge conflicts. Could you please resolve them @ppodolsky? 🙏

thomaseizinger · 2022-12-20T04:21:52Z

Some of the dependency bumps in this PR seem to be incorrect: https://github.com/libp2p/rust-libp2p/actions/runs/3729641763/jobs/6327231245

ppodolsky · 2022-12-20T07:32:57Z

@mxinden Seems something from your commit. Not sure what to do with it

mxinden · 2022-12-20T08:05:19Z

Should be fixed with #3261 merged. Can you update the pull request @ppodolsky?

mxinden · 2022-12-20T08:06:11Z

Mergify can't update your branch to the latest version of master: #3196 (checks)
Can you see if you can address this? I've heard that it is tricky to do for forks coming from organisations but haven't confirmed that. Worst case, can you open this PR from a personal fork instead?

Done, but had to force push rebased commits. I believe organisations' forks are ok if the organisation belongs to you.

Cool thanks! Let's see if mergify is happy now :)

Following up on this, for future pull requests, us being able to merge master ourselfs into your pull request would make both of our lifes a bit easier.

mxinden · 2022-12-20T08:06:59Z

🙏

ppodolsky · 2022-12-20T08:08:13Z

Following up on this, for future pull requests, us being able to merge master ourselfs into your pull request would make both of our lifes a bit easier.

Would be glad to allow but have no idea how to do it

ppodolsky · 2022-12-20T08:20:35Z

Now it is clippy(beta) failing

mxinden · 2022-12-20T08:40:19Z

Now it is clippy(beta) failing

That CI check is not required, i.e. can be fixed in a different pull request. Only the stable clippy check is required.

mxinden · 2022-12-20T08:53:30Z

🎉 Thanks for the help here.

libp2p#3196 forgot to bump `libp2p-uds`. `libp2p-uds` was updated to `libp2p-core` `v0.39.0` thus requiring the version bump. This has happened before, see libp2p#2720.

#3196 forgot to bump `libp2p-uds`. `libp2p-uds` was updated to `libp2p-core` `v0.39.0` thus requiring the version bump. This has happened before, see #2720. Pull-Request: #3502.

ppodolsky force-pushed the dependabot/cargo/multiaddr-0.17.0 branch from bff3fd3 to 61a1b53 Compare December 6, 2022 08:04

ppodolsky changed the title ~~Update multiaddr to 0.17.0~~ build(deps): Update multiaddr to 0.17.0 Dec 6, 2022

thomaseizinger changed the title ~~build(deps): Update multiaddr to 0.17.0~~ deps: Update multiaddr to 0.17.0 Dec 7, 2022

thomaseizinger changed the title ~~deps: Update multiaddr to 0.17.0~~ deps!: Update multiaddr to 0.17.0 Dec 7, 2022

thomaseizinger changed the title ~~deps!: Update multiaddr to 0.17.0~~ deps!: Update multiaddr & multihash to 0.17.0 Dec 7, 2022

thomaseizinger approved these changes Dec 7, 2022

View reviewed changes

thomaseizinger added the send-it label Dec 12, 2022

mxinden previously requested changes Dec 12, 2022

View reviewed changes

Comment thread core/Cargo.toml

mxinden removed the send-it label Dec 12, 2022

ppodolsky mentioned this pull request Feb 17, 2023

Remove clue code from iroh after updating to libp2p with new multihash/multiaddr deps n0-computer/beetle#47

Open

mxinden mentioned this pull request Dec 14, 2022

refactor!: Move ConnectionId and PendingPoint to libp2p-swarm #3221

Closed

2 tasks

thomaseizinger previously approved these changes Dec 19, 2022

View reviewed changes

Comment thread transports/webrtc/CHANGELOG.md Outdated

Comment thread transports/tls/CHANGELOG.md Outdated

Comment thread transports/tls/CHANGELOG.md Outdated

thomaseizinger added the send-it label Dec 19, 2022

dependabot Bot and others added 6 commits December 19, 2022 07:50

build(deps): Also bump multihash requirement from 0.16.0 to 0.17.0

7faf3d8

*: Update libp2p-core

4ec18a4

Update transports/webrtc/CHANGELOG.md

aceea1e

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

Update transports/tls/CHANGELOG.md

08b74d2

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

Update transports/tls/CHANGELOG.md

2666593

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

thomaseizinger previously approved these changes Dec 19, 2022

View reviewed changes

Merge branch 'master' into dependabot/cargo/multiaddr-0.17.0

23a0b72

mxinden approved these changes Dec 19, 2022

View reviewed changes

mxinden mentioned this pull request Dec 19, 2022

fix(libp2p): Don't specify monorepo dev dependencies by version #3261

Merged

4 tasks

jxs mentioned this pull request Dec 19, 2022

mergify: Automatic approve and run on merge commit #3263

Closed

rkuhn mentioned this pull request Dec 19, 2022

chore: Update libipld to 0.15 ipfs-rust/libp2p-bitswap#40

Closed

This was referenced Dec 19, 2022

build(deps): Update multihash requirement from 0.16 to 0.18 #3206

Closed

build(deps): Update multiaddr requirement from 0.16.0 to 0.17.0 #3193

Closed

thomaseizinger removed the send-it label Dec 20, 2022

Merge branch 'master' into dependabot/cargo/multiaddr-0.17.0

810a635

mxinden added the send-it label Dec 20, 2022

mergify Bot merged commit 929cbb4 into libp2p:master Dec 20, 2022

mxinden added a commit to mxinden/rust-libp2p that referenced this pull request Feb 24, 2023

fix(uds): Bump version

7c46e6e

libp2p#3196 forgot to bump `libp2p-uds`. `libp2p-uds` was updated to `libp2p-core` `v0.39.0` thus requiring the version bump. This has happened before, see libp2p#2720.

mxinden mentioned this pull request Feb 24, 2023

fix(uds): Bump version #3502

Merged

4 tasks

mergify Bot pushed a commit that referenced this pull request Feb 24, 2023

fix(uds): Bump version

1a9cf4f

#3196 forgot to bump `libp2p-uds`. `libp2p-uds` was updated to `libp2p-core` `v0.39.0` thus requiring the version bump. This has happened before, see #2720. Pull-Request: #3502.

umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024

deps!: Update multiaddr & multihash to 0.17.0 (libp2p#3196)

4bd3e3e

Uh oh!

Conversation

ppodolsky commented Dec 6, 2022 • edited by thomaseizinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes

Uh oh!

b5 commented Dec 6, 2022

Uh oh!

thomaseizinger left a comment

Choose a reason for hiding this comment

Uh oh!

thomaseizinger commented Dec 7, 2022

Uh oh!

ppodolsky commented Dec 8, 2022

Uh oh!

thomaseizinger commented Dec 12, 2022

Uh oh!

thomaseizinger commented Dec 12, 2022

Uh oh!

mxinden left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mergify Bot commented Dec 12, 2022

Uh oh!

mxinden commented Dec 14, 2022

Uh oh!

ppodolsky commented Dec 14, 2022

Uh oh!

thomaseizinger commented Dec 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomaseizinger commented Dec 19, 2022

Uh oh!

ppodolsky commented Dec 19, 2022

Uh oh!

thomaseizinger commented Dec 19, 2022

Uh oh!

mergify Bot commented Dec 19, 2022

Uh oh!

thomaseizinger commented Dec 20, 2022

Uh oh!

ppodolsky commented Dec 20, 2022

Uh oh!

mxinden commented Dec 20, 2022

Uh oh!

mxinden commented Dec 20, 2022

Uh oh!

mxinden commented Dec 20, 2022

Uh oh!

ppodolsky commented Dec 20, 2022

Uh oh!

ppodolsky commented Dec 20, 2022

Uh oh!

mxinden commented Dec 20, 2022

Uh oh!

mxinden commented Dec 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ppodolsky commented Dec 6, 2022 •

edited by thomaseizinger

Loading