docs: add brew trust#105
Open
robertoschiavone wants to merge 1 commit into
Open
Conversation
robertoschiavone
requested review from
jakecorrenti,
slp and
tylerfanelli
as code owners
tylerfanelli
approved these changes
Jun 15, 2026
tylerfanelli
left a comment
tylerfanelli
left a comment
Collaborator
There was a problem hiding this comment.
Sounds reasonable to me, but how would this work with <6.0.0? I imagine with no knowledge of a trust subcommand and subsequent error, users would think this is failing?
jakecorrenti
requested changes
Jun 15, 2026
Comment on lines
+27
to
+28
| brew tap slp/krun | ||
| brew trust slp/krun |
Collaborator
There was a problem hiding this comment.
while you're here, these should also be libkrun/krun instead of slp/krun
There was a problem hiding this comment.
Yeah, this is so confusing... lack of attention to detail.
Collaborator
There was a problem hiding this comment.
the tap name just changed since we moved the project into a different org, so it just hadn't trickled into the docs yet
Signed-off-by: Roberto Schiavone <5054879+robertoschiavone@users.noreply.github.com>
NeckBeardPrince
approved these changes
Jun 16, 2026
jakecorrenti
requested changes
Jun 16, 2026
jakecorrenti
left a comment
jakecorrenti
left a comment
Collaborator
There was a problem hiding this comment.
Can you also fix the CI as well since it's related to this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since June 11 2026, Homebrew 6.0.0 introduces a new Tap Trust mechanism. When following the README, I got the following error
so I am proposing to add the
brew trustcommand to the README.I also took the liberty to add shell highlighting to all code blocks: