Repository navigation
Conversation
Source test_output_strings as one path when the checkout directory contains spaces. Run the existing Linux CMake job from a spaced checkout to retain regression coverage. All four output tests fail on the unchanged checkout and pass with the quoted paths on macOS. The other five baseline CTest cases pass. Assisted-by: OpenAI Codex
|
Thanks |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quote the fixture paths in four output test scripts so CMake tests work from checkouts with spaces. Run the existing Linux CMake job from a spaced checkout.
All four output tests fail before the fix and pass after it on macOS and Linux. Fork CI passes all 9 CTests.