Add circumcenter calculation, unit tests#4461
Conversation
The assert itself should have been handling conversions, but for complex/int the direct conversion wasn't allowed.
This fixes T=complex issues and is more efficient if the compiler doesn't inline here.
We really need to fix this, not keep working around it...
|
Job Coverage, step Generate coverage on 329a2d7 wanted to post the following: CoverageInconsistent report tags were found between the head and base reports. Inconsistent tags: This comment will be updated on new commits. |
jwpeterson
left a comment
jwpeterson
left a comment
There was a problem hiding this comment.
My only request (over IM) was to update the docs regarding collinear points, thanks!
|
Feels silly to re-run CI for a comment change, but I don't need this as urgently as I thought (#4442 is ready without it and it'll be at least a couple weeks before the next phase of that needs it) so I'll just turn on auto-merge here and we'll see if there's been any downstream breakage during the last 19 hours. |
3 participants
I need this to expand all_rbb() compatibility in #4442, but it's pretty self-contained too.