Skip to content

Add cluster-wide indication for network instance of cluster #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eriknordmark merged 2 commits into from
Jul 27, 2026
+83 −49
Merged

Add cluster-wide indication for network instance of cluster #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ee41e7
Add cluster-wide indication for network instance of cluster
naiming-zededa Jul 23, 2026
5a7e3d4
Generated files for Add cluster-wide indication for network instance …
naiming-zededa Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 58 additions & 37 deletions go/config/netinst.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions proto/config/netinst.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,19 @@ message NetworkInstanceConfig {
// When enabled, LLDP frames (EtherType 0x88cc) are not dropped or suppressed
// by the forwarding plane.
bool forward_lldp = 52;

// cluster_wide - Determines whether this network instance is device-specific
// or shared across an Edge Node Cluster (ENC).
// If false (default), the network instance configuration is only downloaded
// to and instantiated on this individual device.
// If true, the network instance configuration is downloaded to every device
// that is a member of the Edge Node Cluster, and the network instance is
// instantiated identically on each of them. This allows application
// instances running on any node of the cluster to attach to the same
// logical network instance, which is required e.g. for app instances that
// may be relocated between cluster nodes. This may be useful for native
// kubernetes applications using the network instance.
bool cluster_wide = 53;

@milan-zededa milan-zededa Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does cluster_wide mean that each device gets its own isolated replica of the network instance (with a different UUID but the same configuration)? If so, I'm not sure cluster_wide is the best name, since the network instance doesn't actually provide connectivity between applications running on different devices.

@naiming-zededa naiming-zededa Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. this will be no different from today's ENC, same UUID to all the nodes. But this is preparing for native kubernetes applications, which does not have any application reference to detail of NI inside pillar. This is to make a difference from device only NI, like those default NI generated.

}

// VLAN Access Port config applied to physical port(s) attached to a Switch Network Instance.
Expand Down
Loading
Loading