Skip to content

Import archive-based cargo-binstall support#41

Draft
leynos wants to merge 1 commit into
mainfrom
cargo-binstall-support
Draft

Import archive-based cargo-binstall support#41
leynos wants to merge 1 commit into
mainfrom
cargo-binstall-support

Conversation

@leynos

@leynos leynos commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Summary

This branch carries the pre-implementation ExecPlan for importing archive-based cargo binstall support into rendered app projects. It plans the migration from the current direct-binary pkg-fmt = "bin" release contract to archive-based Linux GNU cargo-binstall artefacts staged through leynos/shared-actions.

Execplan: docs/execplans/cargo-binstall-support.md

Review walkthrough

Validation

  • make test 2>&1 | tee /tmp/test-agent-template-rust-cargo-binstall-support-plan.out: 50 passed, 1 skipped in 55.93s.
  • make test 2>&1 | tee /tmp/test-agent-template-rust-cargo-binstall-support-plan-amend.out: 50 passed, 1 skipped in 47.42s.
  • git diff --check: passed with no output.

Notes

This is a pre-implementation plan pull request. It does not change generated template behaviour yet; it authorizes the follow-up implementation to add rendered contract tests, update app-only cargo-binstall metadata, introduce app-only release staging configuration, and move rendered app release staging onto the current pinned leynos/shared-actions revision.

The plan records that leynos/shared-actions currently resolves to 455d9ed03477c0026da96c2541ca26569a74acac, and the future implementation should use that pin unless a fresh audit deliberately updates the rendered workflow assertions in the same change.

Summary by Sourcery

Documentation:

  • Introduce a detailed execplan describing constraints, risks, milestones, and acceptance criteria for adopting archive-based cargo-binstall support and shared release staging actions in rendered app projects.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3620c61e-0787-4da0-b81c-446706a0fa76

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cargo-binstall-support

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai

sourcery-ai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Reviewer's Guide

Adds a detailed ExecPlan document that defines how archive-based cargo-binstall support will be introduced for rendered app projects, covering constraints, risks, implementation milestones, and acceptance criteria without yet changing any template behaviour.

File-Level Changes

Change Details Files
Introduce an ExecPlan documenting the future migration from direct-binary app releases to archive-based cargo-binstall artefacts using leynos/shared-actions.
  • Describe the purpose and desired observable outcomes for moving rendered app projects to archive-based cargo-binstall releases while keeping lib projects unchanged.
  • Specify constraints on where and how changes must be made in the template (app-only, under template/, proved via rendered contract tests, and with SHA-pinned GitHub Actions).
  • Define operational tolerances and explicit escalation points around shared-action suitability, breaking existing binary naming contracts, test failures, and adding new Copier prompts.
  • Identify key risks such as shared-action revision drift, differing target matrices, and brittleness of workflow tests, along with mitigation strategies.
  • Record current progress, surprises, discoveries, and design decisions from auditing Dear Diary commits and leynos/shared-actions usage, including the chosen shared-actions pin.
  • Lay out a milestone-based implementation plan (tests first, then metadata, release-staging config, workflow updates, docs, and validation) plus concrete acceptance criteria for the eventual implementation.
docs/execplans/cargo-binstall-support.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant