Install Whitaker from the released installer in generated projects#28
Conversation
Replace the git-revision `cargo install` of `whitaker-installer` with the released 0.2.5 crate in both places the template provisions it: the generated CI workflow (via `cargo binstall`, which the generated job already uses for its other Rust tools) and the generated Makefile's `whitaker` bootstrap target (via `cargo install --locked --version`, since local machines may lack binstall). This matches the estate-standard adoption pattern (see leynos/netsuke#410). The `--cranelift` flag is retained for the generated projects' Cranelift debug builds.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 54 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b8db23830
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The generated CI pinned `generate-coverage` at a revision whose recorded cargo-nextest 0.9.120 checksums no longer match the published binaries, failing the act-validation run of the rendered `use_rust` project. The new pin includes the upstream checksum corrections (leynos/shared-actions#285, #287, #289) and the binstall-ensure fix (#296).
Add `--locked` to the whitaker-installer cargo-binstall invocation in the generated CI workflow so that binstall's compile fallback resolves dependencies from the published lockfile, keeping fallback builds reproducible. Run-block expressions already use plain shell variables, so no further indirection was needed. The template carried the same unverified CodeScene CLI installer pattern flagged on msgspec-crockford#9: the step piped the downloaded installer straight into bash and only afterwards ran `sha256sum -c -` against a file the run block never wrote. Download the installer to a file first, verify it against `CODESCENE_CLI_SHA256` when the variable is set (failing on mismatch), emit a notice and skip verification when it is unset, and only then execute the verified script. Also align the generate-coverage shared-action pin with the estate-wide `455d9ed0` revision expected by the act-validation contract tests, which were failing on the stale `296dc4aa` pin.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
The generated CI pinned `generate-coverage` at a revision whose recorded cargo-nextest 0.9.120 checksums no longer match the published binaries, which fails the act-validation run of the rendered `use_rust` project. Move the pin to a revision carrying the upstream checksum corrections (leynos/shared-actions#285, #287, #289) and the binstall-ensure fix (#296), and update the CI contract and helper fixture to expect the new revision so the pin and the contract cannot drift apart again.
1 participant
Summary
This branch aligns the template's Whitaker provisioning with the estate-standard pattern used in leynos/netsuke#410 and the tier 1–2 rollout. Projects generated with
use_rust=truepreviously builtwhitaker-installerfrom a pinned git revision in two places; both now install the released 0.2.5 crate. The--craneliftinstaller flag is retained because generated projects build with the Cranelift debug backend.Review walkthrough
WHITAKER_INSTALLER_REVenvironment variable becomesWHITAKER_INSTALLER_VERSION: '0.2.5'and the install step usescargo binstall, which the generated job already relies on for its other Rust tooling.whitakerbootstrap target installs the released crate withcargo install --locked --version "$(WHITAKER_INSTALLER_VERSION)"(kept ascargo installbecause contributor machines may lack binstall).Validation
make test(render and contract suites): 33 passed, 2 skipped.WITH_ACT=1 make test(act-validation suite against a Podman socket, act v0.2.80): 33 passed, 2 skipped.