Add Windows code-signing and macOS notarization to release workflow#63
Open
lextiz wants to merge 4 commits into
Open
Add Windows code-signing and macOS notarization to release workflow#63lextiz wants to merge 4 commits into
lextiz wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
releasethat writes a base64 PFX fromsecrets.WINDOWS_CERTIFICATE_PFX_BASE64, locatessigntool.exe, and signstarget/release/posturewatch.exewith/fd SHA256, timestamping, and the provided password.release-macosthat decodes a P12 (secrets.MACOS_CERTIFICATE_P12_BASE64) into a temporary keychain and runscodesign --options runtime --timestampusingsecrets.MACOS_CODESIGN_IDENTITY.xcrun notarytool submitwhen Apple notarization secrets (MACOS_NOTARY_APPLE_ID,MACOS_NOTARY_TEAM_ID,MACOS_NOTARY_APP_PASSWORD) are present.if:conditionals so they run only when the corresponding secrets are set and otherwise leave the release process unchanged.Testing
cargo fmtwhich succeeded.cargo clippy -- -D warningswhich completed without warnings.cargo testwhich ran the unit test suite (46 tests) and all tests passed.cargo buildwhich completed successfully.Codex Task