Skip to content

fix: correct inverted segment condition logic in docs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
voj-tech-j merged 2 commits into from
Aug 15, 2026
Merged

fix: correct inverted segment condition logic in docs #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62e409b
fix: correct inverted segment condition logic in docs
voj-tech-j Aug 15, 2026
adaf955
chore: release 1.5.1
voj-tech-j Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.5.1] - 2026-08-15

### Fixed
- Corrected the segment condition documentation on `SegmentConditionGroup`: conditions **within a group** are joined by `OR`, and **groups** are joined by `AND` — i.e. `(A OR B) AND (C OR D)`. The previous docstring stated the inverse. No behaviour change — the API has always evaluated segments this way, and no code paths were touched. Worth a read if you built a segment against the old description, since it may target a wider or narrower audience than you intended.

## [1.5.0] - 2026-08-14

Covers the reworked bulk contact import (TPL-2105) and the duplicate-create fix.
Expand Down Expand Up @@ -283,7 +288,8 @@ the exact same payloads.
`ValidationError`, `NotFoundError`, `ConflictError`, `BadRequestError`,
`ServerError`)

[Unreleased]: https://github.com/lettr/lettr-python/compare/v1.4.0...HEAD
[Unreleased]: https://github.com/lettr/lettr-python/compare/v1.5.1...HEAD
[1.5.1]: https://github.com/lettr/lettr-python/compare/v1.5.0...v1.5.1
[1.5.0]: https://github.com/lettr/lettr-python/compare/v1.4.0...v1.5.0
[1.4.0]: https://github.com/lettr/lettr-python/compare/v1.3.0...v1.4.0
[1.3.0]: https://github.com/lettr/lettr-python/compare/v1.2.0...v1.3.0
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "hatchling.build"

[project]
name = "lettr"
version = "1.5.0"
version = "1.5.1"
description = "Official Python SDK for the Lettr Email API"
readme = "README.md"
license = "MIT"
Expand Down
3 changes: 2 additions & 1 deletion src/lettr/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,8 @@ class AudienceSegment:
"""An audience segment.

``condition_groups`` is kept as a list of raw dicts mirroring the
API shape (groups joined by OR, conditions within a group joined by AND).
API shape (conditions within a group joined by OR, groups joined by
AND) -- i.e. (A OR B) AND (C OR D).
"""

id: str
Expand Down
Loading