Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents topic translations: customers can store a name and description per language on each topic, and the email preferences page shows the one matching its language. The multilingual-campaigns pages also stop saying topic names can't be translated.
Do not merge until the lettr-app change is deployed: https://github.com/TOPOL-io/lettr/pull/502
Changes
learn/audience/topics.mdx. New## Translationssection: the fallback to the default name, adding a language, why a translation without a description shows none, the preview check, and that an API/MCP update replaces the whole set.learn/multilingual-campaigns/sending-and-results.mdxandintroduction.mdx. Replace the "can't be translated" wording and link to/learn/audience/topics#translations.learn/audience/email-preferences.mdx. Cross-link from the Page Language section.Linear Issue
https://linear.app/topol/issue/TPL-2656/task-9-docs-pr-for-topic-translations-in-lettr-docs
Test Plan
npm run dev, open/learn/audience/topics#translations, and check the section renders and the anchor jumps to it.sending-and-results,introductionandemail-preferences, click the new links; each lands on the Translations section.