Skip to content

Update example to match generator code#1

Open
JaimeValdemoros wants to merge 4 commits into
letsdiscodev:mainfrom
JaimeValdemoros:jvg/update-disco-json
Open

Update example to match generator code#1
JaimeValdemoros wants to merge 4 commits into
letsdiscodev:mainfrom
JaimeValdemoros:jvg/update-disco-json

Conversation

@JaimeValdemoros

@JaimeValdemoros JaimeValdemoros commented Feb 26, 2026

Copy link
Copy Markdown

Taking https://github.com/letsdiscodev/disco-daemon/blob/588055bf7c865121676b06ab2b1babf810b05b1b/disco/utils/deploymentflow.py#L1003 as a reference:

  • "type": "generator" instead of "type": "static"
  • publicPath must be set
  • Image needs to contain release files at build time
    • Which necessarily means image needs to be built with output files baked in
    • As a result a Dockerfile is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant