feat: name phpMyAdmin's language cookie so a language picked in lerd wins - #38
Merged
Merged
Conversation
…wins phpMyAdmin stores the language in pma_lang from the first page it serves and reads it ahead of Accept-Language, so a language picked in lerd only reached it until it had been opened once. The preset now names pma_lang and pma_lang_https under dashboard_locale_cookies, which lerd 1.36.0 holds back while a language is picked. The key is new in schema 2, so phpMyAdmin is authored there and the tree older binaries read keeps the preset they already have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpMyAdmin keeps the language in pma_lang from its first page on, ahead of the Accept-Language lerd sends. The preset now names that cookie under dashboard_locale_cookies, a schema 2 key lerd 1.36.0 understands. The tree older binaries read keeps the preset unchanged.