feat: give fresh Drupal projects a default database - #95
Merged
Merged
Conversation
A recommended-project scaffold names no database driver until the Drupal installer runs, so lerd env found nothing to wire and lerd setup --all could not finish on a new project. Each Drupal definition now sets env.default_service to mysql, which lerd uses only when the project names no database at all, so a site already on PostgreSQL or SQLite keeps its driver. Older binaries do not know the key and ignore it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh Drupal project has no database settings yet, so there is nothing for lerd to detect, and lerd setup --all could not finish on one. The four Drupal definitions now name mysql through the new optional env.default_service key, so a new project gets it wired up while an existing site on PostgreSQL or SQLite keeps the database it already uses. Binaries that predate the key ignore it and behave exactly as they do today.
Refs lerd-env/lerd#2057