feat: add yii2 definition - #91
Merged
Merged
Conversation
The index entry gave its detect rules as strings, which lerd cannot parse, so the whole store index would have failed to load on every install. It now uses the same rule objects as every other entry, and the framework is named yii with 2 as its version so Yii 3 can join it later. Detection keys on yiisoft/yii2 alone, because Yii 3 ships a yii console script too. db.php is handed straight to yii\db\Connection, which rejects unknown keys, so url_key is none and lerd no longer writes APP_URL into it. The queue worker runs queue/listen, since queue/run drains the queue and exits, which left the unit restarting forever. The redis wiring is gone because it overwrote the connection class in db.php, and so is sqlite, which needs a project path lerd cannot express in env values yet. Tinker, migrate:create and gii are dropped because none of them worked from lerd, along with the permissions step the Yii installer already covers. Fixtures only show when the project has a fixtures folder, and the definition now carries the Yii leaf mark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.