fix: offer Drupal's Import config only when there is config to import - #90
Merged
Merged
Conversation
A fresh Drupal has no exported configuration, and drush refuses to import an empty sync directory because it would delete the site's configuration. lerd setup --all runs every setup step, so it aborted on every new Drupal project right after the installer had succeeded. The step is now offered only once config/sync holds an exported site, in the Drupal definitions and in the drush package alike.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh Drupal has no exported configuration, and drush refuses to import an empty sync directory because applying it would delete the site's configuration. lerd setup --all runs every setup step, so on a new Drupal project it aborted at Import config right after the installer had succeeded, which is how the release test run found it.
Import config is now offered only once config/sync holds an exported site, in each Drupal definition and in the drush package alike. A file check is a key every binary already reads, so older installs pick this up as it is.