Skip to content

Make dependencies optional#44

Open
cdonovick wants to merge 2 commits into
masterfrom
setup
Open

Make dependencies optional#44
cdonovick wants to merge 2 commits into
masterfrom
setup

Conversation

@cdonovick

Copy link
Copy Markdown
Collaborator

No description provided.

@cdonovick

Copy link
Copy Markdown
Collaborator Author

resolves #37

@cdonovick cdonovick requested a review from leonardt June 1, 2019 17:02

@leonardt leonardt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume we need to update downstream tools that require FP/SMT need to update their flows to install the extras? I'm thinking peak, lassen, metamapper, garnet. Any others?

Comment thread .travis.yml
- pip install -r requirements.txt
- pip install pytest-cov
- pip install -e .
- pip install -e .[TEST]

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@cdonovick

cdonovick commented Jun 1, 2019

Copy link
Copy Markdown
Collaborator Author

@leonardt
Yes, you are correct we will need to update downstreams tools.
I am aware of the following dependencies:
Lassen - hwtypes[FP]
Peak - hwtypes[SMT]
Fault - hwtypes[Z3] (for constrained random)

@Kuree

Kuree commented Jun 1, 2019

Copy link
Copy Markdown

Is there any way to install all in a single command as in
pip install git+https://github.com/leonardt/hwtypes@HASH#egg=hwtypes? GarnetFlow uses this pip command to install packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants