Honor still alpha, SIGINT, and Source Media ready timeout in headless render - #21
Merged
Conversation
… render. Follow-ups left uncommitted when #20 merged: transparent Stage stills match the editor, still capture maps abort to exit 130, and the ready gate no longer hangs forever on missing display aspect.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbortSignaland maps abort to exit 130, matching video encode.These were local follow-ups left uncommitted when #20 merged.
Test plan
transparent, still abort → 130, and ready-gate timeoutpnpm testlocally (or CI) on this branchmockstudio rendera transparent-Stage PNG and Ctrl+C a still renderNote
Medium Risk
Changes export alpha semantics and CLI interrupt/headless readiness behavior on the render path; risk is mitigated by unit tests and parity with existing video abort handling.
Overview
Headless still rendering now matches the editor for transparency:
buildStillExportRequestsetstransparentwhen the Stage is transparent and the format is PNG or WebP (JPEG stays opaque).Still capture accepts an
AbortSignal, passes it through Playwright’swithHeadlessPage, and maps abort to exit 130 with the same interrupted JSON envelope as video encode.The headless ready gate no longer waits forever when bound Source Media never publishes a display aspect—it rejects after 30s (configurable in tests via
displayedMediaTimeoutMs).Reviewed by Cursor Bugbot for commit e2140bc. Bugbot is set up for automated code reviews on this repo. Configure here.