Enforce image height and width from 0-1024 pixels - #13
Open
ckuethe wants to merge 1 commit into
Open
Conversation
0 is treated as model default, and anything over 1024 is an error. CLI, API, and WUI all enforce these and give useful errors. I went with 1024 as the upper limit since I have no evidence that any models are trained on larger inputs; if you want a bigger output use upscaling.
Member
|
1024 is not even close to being reasonable. 4096 sounds more like it |
Member
|
also, I don't like adding hard limits. This limit should only be in the index.html and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0 is treated as model default, and anything over 1024 is an error. CLI, API, and WUI all enforce these and give useful errors.
I went with 1024 as the upper limit since I have no evidence that any models are trained on larger inputs; the internet says to use upscaling if you want larger images
Fixes #11