Skip to content

fix: prevent core dump in PM V2 in case of incomplete cmd line - #950

Merged
leejet merged 1 commit into
leejet:masterfrom
akleine:photomaker2_fix
Nov 9, 2025
Merged

fix: prevent core dump in PM V2 in case of incomplete cmd line#950
leejet merged 1 commit into
leejet:masterfrom
akleine:photomaker2_fix

Conversation

@akleine

@akleine akleine commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

docs: add hint about PM2 args in command line
for details also see #949

docs: add hint about PM2 args in command line

@wbruna wbruna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leejet
leejet merged commit 0fa3e1a into leejet:master Nov 9, 2025
9 checks passed
@akleine
akleine deleted the photomaker2_fix branch November 9, 2025 21:23
@akleine

akleine commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

Thank you very much!

Unfortunately the user has some more chances here to do bad things, for example he could delete or add one of the images inside the folder after running face_detect.py.
In such cases sd.cpp will terminate with an assert and backtrace.

Do you think that sd.cpp should be more "waterproof" in such cases ?
If you confirm I would care a little bit more about that, at least give the user some more feedback what is going wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants