move generate + image format and base64 encoding into new function generate_and_encode() - #1418
Closed
Korsar13 wants to merge 1 commit into
Closed
move generate + image format and base64 encoding into new function generate_and_encode()#1418Korsar13 wants to merge 1 commit into
Korsar13 wants to merge 1 commit into
Conversation
…nerate_and_encode()
Owner
|
Thanks for the PR. The safe part to extract is mostly just encoding/base64, which would only reduce a small amount of duplication. The current PR reduces more code by also moving generation into the helper, but that changes route/job control flow and error handling. Given that tradeoff, I’d prefer to keep the current code explicit and close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.