feat: prioritize gguf and safetensors formats for embeddings and LoRAs - #1169
Merged
Conversation
Models available as multiple file types were likely converted from one another, so we should prioritize native, safer and more efficient formats.
Owner
|
I’m not entirely sure whether this is necessary here. Generally, GGUF files include the corresponding quantization format in their filenames, so they differ from the original version. |
Contributor
Author
|
My main concern is with the current .pt priority. I agree it doesn't matter that much for .gguf versus .safetensors (as I also don't see a strong reason for preferring .safetensors over .gguf, either; but I can adapt the PR if there is one). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models available as multiple file types were likely converted from one another, so we should prioritize native, safer and more efficient formats.