Skip to content

feat: add support for underline style lora of flux - #1103

Merged
leejet merged 5 commits into
masterfrom
flux_underline_lora
Dec 18, 2025
Merged

feat: add support for underline style lora of flux#1103
leejet merged 5 commits into
masterfrom
flux_underline_lora

Conversation

@leejet

@leejet leejet commented Dec 16, 2025

Copy link
Copy Markdown
Owner

No description provided.

@ddpasa

ddpasa commented Dec 16, 2025

Copy link
Copy Markdown

This improves #1092 . Text encoders are still not completely loaded, but it looks like the transformer is fine after this.

@leejet

leejet commented Dec 17, 2025

Copy link
Copy Markdown
Owner Author

@ddpasa This update should make the LoRA for text_encoders work. However, I couldn’t find a corresponding LoRA to test it with. If you could upload a LoRA to HuggingFace or Civitai for me to download and test, I would really appreciate it.

@ddpasa

ddpasa commented Dec 17, 2025

Copy link
Copy Markdown

@ddpasa This update should make the LoRA for text_encoders work. However, I couldn’t find a corresponding LoRA to test it with. If you could upload a LoRA to HuggingFace or Civitai for me to download and test, I would really appreciate it.

Thanks @leejet , I uploaded an example Lora here: https://huggingface.co/ddhfacc/lora_debug/tree/main It has T5 and Clip layers as well.

Pulling the additional commit did not reduce the number of unused lora layers for me.

@leejet

leejet commented Dec 17, 2025

Copy link
Copy Markdown
Owner Author

@ddpasa Everything should be ok now.

@ddpasa

ddpasa commented Dec 17, 2025

Copy link
Copy Markdown

@ddpasa Everything should be ok now.

I think so, testing now. I don't see similar errors in the log after 6bff0d9. I'll generate a few and compare with Comfy.

@ddpasa

ddpasa commented Dec 17, 2025

Copy link
Copy Markdown

I generated multiple images, as far as I can tell, it works great now. Thanks for fixing this!

@leejet
leejet merged commit 8e9f3a4 into master Dec 18, 2025
8 of 9 checks passed
@leejet
leejet deleted the flux_underline_lora branch December 21, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants