[OU-FIX] website_sale_collect: fix invalid SQL in pickup-address backfill#112
Open
dnplkndll wants to merge 1 commit into
Open
[OU-FIX] website_sale_collect: fix invalid SQL in pickup-address backfill#112dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
…fill _mark_pickup_auxiliary_addresses built an UPDATE whose WHERE used comma-separated conditions instead of AND (plus `parent_id != False` and a trailing comma) — invalid SQL that raises syntax error the moment a pickup carrier (delivery_type='in_store') exists. CI is green only because the demo seed has no in_store carrier, so the loop never runs. Use AND, IS NOT DISTINCT FROM for the nullable state_id/country_id (matches pickup locations without a state/country), parent_id IS NOT NULL, and pass .id (not the recordset) for the relational params. Bug from OCA#5740 (pedrobaeza).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_mark_pickup_auxiliary_addressesbuilds anUPDATEwhoseWHEREuses comma-separated conditions instead ofAND(plusparent_id != Falseand a trailing comma) — invalid SQL that raises a syntax error as soon as a pickup carrier (delivery_type='in_store') exists. CI stays green only because the demo seed has no in_store carrier, so the loop body never executes; a real prod migration with in-store pickup would crash.Fix:
ANDbetween conditions,IS NOT DISTINCT FROMfor the nullablestate_id/country_id(so pickup locations without a state/country still match),parent_id IS NOT NULL, and pass.id(not the recordset) for the relational params.Bug originates in OCA#5740 (pedrobaeza) — worth reporting upstream.