Skip to content

Fix: Handle all ConstantInfo types and improve error message #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JasonGross wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: Handle all ConstantInfo types and improve error message #5

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9f1c38
Initial plan
Copilot Dec 20, 2025
24358db
Fix: Handle all ConstantInfo types and improve error message
Copilot Dec 20, 2025
a7743e7
Update Comparator/Compare.lean
JasonGross Dec 20, 2025
9d18645
Update Comparator/Compare.lean
JasonGross Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions Comparator/Compare.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,18 @@ partial def loop : CompareM Unit := do

end Compare

/-- Get a human-readable name for the kind of constant -/
def constantKindName (info : Lean.ConstantInfo) : String :=
match info with
| .axiomInfo .. => "axiom"
| .defnInfo .. => "def"
| .thmInfo .. => "theorem"
| .opaqueInfo .. => "opaque"
| .quotInfo .. => "quot"
| .inductInfo .. => "inductive"
| .ctorInfo .. => "constructor"
| .recInfo .. => "recursor"

def compareAt (challenge solution : ExportedEnv) (targets : Array Lean.Name) :
Except String Unit := do
let mut worklist := #[]
Expand All @@ -68,8 +80,14 @@ def compareAt (challenge solution : ExportedEnv) (targets : Array Lean.Name) :
let (challengeConst, solutionConst) ←
match challengeConst, solutionConst with
| .thmInfo cc, .thmInfo sc
| .axiomInfo cc, .axiomInfo sc => pure (cc.toConstantVal, sc.toConstantVal)
| _, _ => throw s!"Challenge and solution constant kind don't match: '{target}'"
| .axiomInfo cc, .axiomInfo sc
| .defnInfo cc, .defnInfo sc
| .opaqueInfo cc, .opaqueInfo sc
| .quotInfo cc, .quotInfo sc
| .inductInfo cc, .inductInfo sc
| .ctorInfo cc, .ctorInfo sc
| .recInfo cc, .recInfo sc => pure (cc.toConstantVal, sc.toConstantVal)
| c, s => throw s!"Challenge and solution constant kind don't match: '{target}' (challenge: {constantKindName c}, solution: {constantKindName s})"

if challengeConst != solutionConst then
throw s!"Challenge and solution theorem statement do not match: '{target}'"
Expand Down