feat(QuantumMechanics): add algebraic properties for mulOperator#1448
Conversation
|
Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally. If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks. If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip. Important: If a reviewer adds an |
|
This looks good to me. One comment is that it would be good to have more documentation than is available at the moment. Some doc strings for key lemmas, and a general elaboration on "why" behind the code would be great for readability and would improve the file greatly. |
|
Thanks, I'll aim to improve the documentation for this and other QM files in the near future. |
|
Okayy sounds good, just one more question: For smul and composition, the PR (and existing code) follow a nice proof pattern. However, for add, we only get the inequality |
|
awaiting-author |
|
That's a good point. The condition |
|
Okayy looks good to me, will tag as reviewer approved :) |
Adds some basic results about multiplication operators and smul/neg/add/sub:
c • 𝓜 μ f ≤ 𝓜 μ (c • f)with equality whenc ≠ 0,𝓜 μ (-f) = -𝓜 μ f,𝓜 μ f + 𝓜 μ g ≤ 𝓜 μ (f + g)(and asubvariant).