Skip to content

chore(AlgebraicGeometry/GammaSpecAdjunction): remove an erw#38763

Open
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:E_44
Open

chore(AlgebraicGeometry/GammaSpecAdjunction): remove an erw#38763
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:E_44

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • rewrites toStalk_stalkMap_toΓSpec by folding the old erw into the surrounding simp only/rw chain

Extracted from #38415

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels Apr 30, 2026
@github-actions
Copy link
Copy Markdown

PR summary 5d69f04e65

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
585 -1 erw

Current commit 5956170647
Reference commit 5d69f04e65

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebraic-geometry Algebraic geometry label Apr 30, 2026
@yuanyi-350 yuanyi-350 mentioned this pull request Apr 30, 2026
60 tasks
Comment on lines -205 to +209
rw [PresheafedSpace.Hom.stalkMap,
simp only [PresheafedSpace.Hom.stalkMap,
← algebraMap_germ (basicOpen (1 : Γ.obj (op X))) _ (by rw [basicOpen_one]; trivial),
← Category.assoc, Category.assoc (CommRingCat.ofHom _), stalkFunctor_map_germ, ← Category.assoc,
X.toΓSpecSheafedSpace_app_eq, X.toΓSpecCApp_spec, Γgerm]
erw [← stalkPushforward_germ _ _ X.presheaf ⊤]
← Category.assoc, Category.assoc (CommRingCat.ofHom _), stalkFunctor_map_germ,
X.toΓSpecSheafedSpace_app_eq, X.toΓSpecCApp_spec, Γgerm,
← Opens.map_top X.toΓSpecSheafedSpace.hom.base, ← stalkPushforward_germ _ _ X.presheaf ⊤]
Copy link
Copy Markdown
Contributor

@dagurtomas dagurtomas Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the more robust rw, it's a bit hard to see what's happening inside the simp only, especially with Category.assoc in both directions:

  rw [PresheafedSpace.Hom.stalkMap,
    ← algebraMap_germ (basicOpen (1 : Γ.obj (op X))) _ (by rw [basicOpen_one]; trivial),
    ← Category.assoc, Category.assoc (CommRingCat.ofHom _), stalkFunctor_map_germ, ← Category.assoc,
    X.toΓSpecSheafedSpace_app_eq, X.toΓSpecCApp_spec, Γgerm,
    ← dsimp% stalkPushforward_germ _ _ X.presheaf ⊤]

@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants