bench: microbenches for the hot mixed base x extension field kernels (chunk 1 of #260)#261
Open
koko1123 wants to merge 1 commit into
Open
bench: microbenches for the hot mixed base x extension field kernels (chunk 1 of #260)#261koko1123 wants to merge 1 commit into
koko1123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunk 1 of the delayed modular reduction plan tracked in #260.
What
Ignored-test microbenches (same pattern as
crates/backend/koala-bear/src/benchmark_poseidons.rs) for the four hot mixed base x extension kernels that later chunks will retile:crates/backend/sumcheck/src/benchmark_product_sumcheck.rs-- product-sumcheck quadratic round (compute_product_sumcheck_polynomialover base-packed evals x extension-packed weights, i.e. thesumcheck_quadratichot loop).crates/whir/src/benchmark_first_round.rs-- WHIR round-0 combine (combine_and_compute_first_round; madepub(crate)so the bench module can reach it, no other production change).crates/backend/poly/src/benchmark_kernels.rs--eval_base_packedandfinger_print_packed(memory-style 2-element and bytecode-style 13-element logup tuples).Each bench first asserts the kernel output against an independent scalar reference computation (recursive
evaluate_sequentialforeval_base_packed, materialized eq-tables for the WHIR combine, plain scalar loops for the rest), so the harness doubles as a regression test when the kernels are rewritten in later chunks.Run with e.g.:
Baseline numbers (Apple Silicon, NEON, current eager kernels)
Checks
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -Dwarningscargo test --release --allChunks 2+ (Algebra::mixed_dot_product, delayed packed-quintic Mul, call-site retiling, NEON dot_product_8) will follow as separate PRs, each gated on these benches plus the E2E XMSS baseline, per the plan in #260.
🤖 Generated with Claude Code